-
Notifications
You must be signed in to change notification settings - Fork 6
Make last_seen field User model optional #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make last_seen field User model optional #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR makes the last_seen field optional in the User model to address DEVP-617. The field can now be null, allowing for cases where user activity tracking is not available.
Key Changes:
- Removed
last_seenfrom required fields in the OpenAPI specification - Added
nullable: trueto thelast_seenfield definition - Updated Python model to use
Optional[datetime]with proper null handling
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| workato-api-spec.yaml | Removed last_seen from required fields and marked it as nullable in the schema |
| src/workato_platform_cli/client/workato_api/models/user.py | Updated field type to Optional[datetime] = None and added nullable handling in to_dict() |
| src/workato_platform_cli/client/workato_api/docs/User.md | Updated documentation to indicate the field is optional |
| openapitools.json | Bumped OpenAPI Generator version from 7.14.0 to 7.16.0 |
| .gitignore | Added .workato-ignore to git ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cmworkato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cmworkato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add optional last_seen field to User model and update API spec
Addresses https://workato.atlassian.net/browse/DEVP-617